Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Improve colors for both N12 and Or Yarok Users #1068

Open
atalyaalon opened this issue Mar 3, 2024 · 7 comments
Open

[Feat] Improve colors for both N12 and Or Yarok Users #1068

atalyaalon opened this issue Mar 3, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request Priority 1 Priority 1
Milestone

Comments

@atalyaalon
Copy link
Contributor

@galraij @MichalOren Please elaborate the changes needed in colors here (separate N12 from Or Yarok)

@atalyaalon atalyaalon added enhancement New feature or request Priority 1 Priority 1 labels Mar 3, 2024
@MichalOren
Copy link
Collaborator

Hi here are some adjsments
image

@MichalOren
Copy link
Collaborator

in addition : Change numbers color according to the icon color
image

@MichalOren
Copy link
Collaborator

head_on_collisions_comparison_percentage +
head_on_collisions_comparison

Keep the colors of our current regular pie as usual + all the text on the side in white

@shaked-hayek
Copy link
Collaborator

shaked-hayek commented Mar 16, 2024

head_on_collisions_comparison_percentage + head_on_collisions_comparison

Keep the colors of our current regular pie as usual + all the text on the side in white

@MichalOren Can you add image example?

in addition : Change numbers color according to the icon color

@MichalOren for n12 or for all?

@MichalOren
Copy link
Collaborator

Hi @shaked-hayek

First question.... kindly keep the gray and change the red. The text on the right side change to white.
image

Second question... only for N12 users
I hope this is more understandable and clear
thanks

@atalyaalon atalyaalon added this to the v0.18.0 milestone Sep 29, 2024
@shaked-hayek
Copy link
Collaborator

@atalyaalon @MichalOren Is this still open or fixed?

@atalyaalon
Copy link
Contributor Author

atalyaalon commented Nov 6, 2024

@galraij please prioritize this and elaborate regarding other changes needed for N12 and/or Or Yarok users

@shaked-hayek until Gal answers and prioritizes, this is not a priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority 1 Priority 1
Projects
None yet
Development

No branches or pull requests

3 participants