Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] axis is partial in img download #1136

Closed
atalyaalon opened this issue Oct 22, 2024 · 6 comments · Fixed by #1141, #1138, #1139, #1140 or #1142
Closed

[Bug] axis is partial in img download #1136

atalyaalon opened this issue Oct 22, 2024 · 6 comments · Fixed by #1141, #1138, #1139, #1140 or #1142
Labels
bug Something isn't working

Comments

@atalyaalon
Copy link
Contributor

Describe the bug
axis is partial in image download

To Reproduce
See injured_count_by_accident_year widget in this newsflash
Y axis numbers are "cut"

Expected behavior
axis should be displayed as it does in the web.

Screenshots
injured_count_by_accident_year (13)

Environment
Browser: Chrome
Environment: Local / Staging / etc.

@atalyaalon
Copy link
Contributor Author

@shaked-hayek can you take a quick look on this one?
I tried to play a little with height, width, margins, and other variables in html2canvas (see branch bug-1136-axis-partial)
However, issue is not fixed (I reverted these changes and they are not in dev nor in prod)

@atalyaalon
Copy link
Contributor Author

@atalyaalon
Copy link
Contributor Author

@shaked-hayek perhaps using another package of html2canvas will solve the issue?
Just wondering whether it can be as simple as that :)

@atalyaalon
Copy link
Contributor Author

Perhaps https://github.com/tsayen/dom-to-image library can be a better fit, but needs testing

@atalyaalon
Copy link
Contributor Author

Also https://github.com/bubkoo/html-to-image is another alternative to check

@atalyaalon
Copy link
Contributor Author

html-to-image didn't have the built in onclone In order to include removeMapControllers
Hence I used html-to-image for most images and html2canvas for map images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment