Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package organization #1

Open
rom1504 opened this issue Sep 11, 2023 · 3 comments
Open

Package organization #1

rom1504 opened this issue Sep 11, 2023 · 3 comments

Comments

@rom1504
Copy link
Contributor

rom1504 commented Sep 11, 2023

Subsampler packages eg

  • ffmpeg
  • clip
  • image-resize
  • whisper

To be used in img2dataset, video2dataset, clip vidéo encode any2dataset etc

Would allow

  • easier maintenance by better scoping
  • experimental subsampler
  • independent optimization
  • more contribution by not having to understand the whole code of eg video2dataset
@rom1504
Copy link
Contributor Author

rom1504 commented Sep 11, 2023

To make that happen first create a template repo defining the interface of a subsampler and providing the minimum boilerplate

@rom1504
Copy link
Contributor Author

rom1504 commented Sep 11, 2023

Then create a simple one as example, eg image resize and try to use it in relevant places

@rom1504
Copy link
Contributor Author

rom1504 commented Sep 11, 2023

If that idea work I think it would be cool to apply the same for readers and writers and maybe distributors. That might be less obvious as they're less reusable than the subsamplers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant