Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix distinct set-returning function #16883

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Nov 20, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix distinct set-returning function

for example

root@0.0.0.0:48000/default> select distinct unnest(split(coalesce(NULL, 'a,b,a,b,c'), ',')) as c1;
┌──────────────────┐
│        c1        │
│ Nullable(String) │
├──────────────────┤
│ a                │
│ b                │
│ c                │
└──────────────────┘
3 rows read in 0.117 sec. Processed 1 rows, 1 B (8.55 rows/s, 8 B/s)

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested a review from sundy-li November 20, 2024 07:28
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 20, 2024
@b41sh b41sh enabled auto-merge November 20, 2024 14:27
@b41sh b41sh added this pull request to the merge queue Nov 20, 2024
Merged via the queue into databendlabs:main with commit 45a58cd Nov 20, 2024
72 checks passed
@b41sh b41sh deleted the fix-distinct-srf branch November 20, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Unnest still does not work for some cases
2 participants