Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing all futures::executor::block_on #4378

Closed
3 tasks
Xuanwo opened this issue Mar 10, 2022 · 3 comments
Closed
3 tasks

Removing all futures::executor::block_on #4378

Xuanwo opened this issue Mar 10, 2022 · 3 comments
Assignees
@Xuanwo
Labels
community-take

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Mar 10, 2022 •
edited
Loading

block_on is a problem proven insides tokio async context, it's better to remove them all:
@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 10, 2022

/assignme

@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 10, 2022

This issue may be overlap with #4361, ping @youngsofun for discussion.

@Xuanwo Xuanwo moved this to 📋 Backlog in Xuanwo's Work Mar 10, 2022
@Xuanwo Xuanwo moved this from 📋 Backlog to 🔨 In Progress in Xuanwo's Work Aug 1, 2022
@Xuanwo Xuanwo mentioned this issue Aug 1, 2022
Merged
@Xuanwo Xuanwo moved this from 🔨 In Progress to 📋 Backlog in Xuanwo's Work Sep 14, 2022
@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 14, 2022

This issue is stall for a long time and is not actionable. Let's close.

@Xuanwo Xuanwo closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2022
@Xuanwo Xuanwo moved this from 📋 Backlog to 📬 Cancel in Xuanwo's Work Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xuanwo Xuanwo

Labels
community-take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xuanwo @databend-bot