Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: implement HiveSource to integrate with new processor #6588

Closed
sundy-li opened this issue Jul 13, 2022 · 8 comments · Fixed by #6584
Closed

Feature: implement HiveSource to integrate with new processor #6588

sundy-li opened this issue Jul 13, 2022 · 8 comments · Fixed by #6584
Labels
C-feature Category: feature

Comments

@sundy-li
Copy link
Member

Summary

Description for this feature.

After #5895 HiveSource is a dummy implementation, so we must turn off enable_new_processor_framework to query hive data.
It's better to make HiveTable read support the new processor.

@sundy-li sundy-li added the C-feature Category: feature label Jul 13, 2022
@BohuTANG
Copy link
Member

BohuTANG commented Jul 13, 2022

We plan to remove the old processor codes #6584, FYI @sandflee

@FANNG1
Copy link

FANNG1 commented Jul 13, 2022

plan to support the new processor in last two weeks. cc @dantengsky

@zhang2014
Copy link
Member

new processor HiveSource is implemented in #6584

@FANNG1
Copy link

FANNG1 commented Jul 13, 2022

@zhang2014 thanks for your work, do you mind to move HiveSource related code to a new PR, we could test and discuss in new PR, #6584 is too large.

@sundy-li
Copy link
Member Author

@zhang2014 thanks for your work, do you mind to move HiveSource related code to a new PR, we could test and discuss in new PR, #6584 is too large.

Agreed. And I think we can apply projection pushdown into HiveSource after we have a separated pr.

@zhang2014
Copy link
Member

This is difficult, but they are all in one commit(f9c68cd) and welcome add some comment in this commit.

@BohuTANG
Copy link
Member

@zhang2014 thanks for your work, do you mind to move HiveSource related code to a new PR, we could test and discuss in new PR, #6584 is too large.

Agreed. And I think we can apply projection pushdown into HiveSource after we have a separated pr.

I think we can wait for @zhang2014 to finish his migration and then start the next work.

@zhang2014
Copy link
Member

@zhang2014 thanks for your work, do you mind to move HiveSource related code to a new PR, we could test and discuss in new PR, #6584 is too large.

Agreed. And I think we can apply projection pushdown into HiveSource after we have a separated pr.

I think we can wait for @zhang2014 to finish his migration and then start the next work.

It's ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants