Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[observability] http tracing #805

Closed
BohuTANG opened this issue Jun 10, 2021 · 7 comments · Fixed by #1657
Closed

[observability] http tracing #805

BohuTANG opened this issue Jun 10, 2021 · 7 comments · Fixed by #1657
Assignees
Labels
C-observability Category: Profiling, tracing community-take

Comments

@BohuTANG
Copy link
Member

BohuTANG commented Jun 10, 2021

Summary

Add REST API to rpc/http for showing logs from the web side.

Reference:
tokio-rs/tracing#884
https://github.com/tokio-rs/console
https://github.com/tokio-rs/tracing/tree/master/tracing-opentelemetry

@BohuTANG BohuTANG added easy-task C-observability Category: Profiling, tracing labels Jun 10, 2021
@BohuTANG BohuTANG added this to the v0.5 milestone Jun 22, 2021
@BohuTANG
Copy link
Member Author

This task is easy after #879, the REST API can read tracing from system.tracing:
SELECT * FROM system.tracing

@BohuTANG BohuTANG reopened this Jul 18, 2021
@jyz0309
Copy link
Contributor

jyz0309 commented Aug 22, 2021

/assignme

@jyz0309
Copy link
Contributor

jyz0309 commented Aug 22, 2021

/help

@databend-bot
Copy link
Member

/assignme -- assign the issue to you
/help -- show help

@jyz0309
Copy link
Contributor

jyz0309 commented Aug 29, 2021

I think this issue needs more discussion, for example: What is the format of Json? What content should be kept in the system.tracing table to be shown in the api.

@BohuTANG
Copy link
Member Author

ok, thank you @jyz0309
The initial design we can make it work and next to choose the pretty format, how about your thoughts?

@jyz0309
Copy link
Contributor

jyz0309 commented Aug 30, 2021

ok, thank you @jyz0309
The initial design we can make it work and next to choose the pretty format, how about your thoughts?

I think you are right. Maybe we can just show the logs in the initial design (v0.5). And in the 0.6 version, we can just format it in the Json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-observability Category: Profiling, tracing community-take
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants