Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor stage related tests #8528

Open
Xuanwo opened this issue Oct 28, 2022 · 0 comments
Open

refactor stage related tests #8528

Xuanwo opened this issue Oct 28, 2022 · 0 comments
Labels
good first issue Category: good first issue stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Oct 28, 2022

Summary

We should use streaming upload to put files directly in the stage instead of in s3.

aws --endpoint-url ${STORAGE_S3_ENDPOINT_URL} s3 cp s3://testbucket/admin/data/ontime_200.csv s3://testbucket/admin/stage/internal/s1/ontime_200.csv >/dev/null 2>&1

This is wrong, and stage's path rule should not be leak.
@Xuanwo Xuanwo added the good first issue Category: good first issue label Oct 28, 2022
@Xuanwo Xuanwo moved this to 📋 Backlog in Xuanwo's Work Oct 28, 2022
@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Category: good first issue stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Xuanwo