Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: make store/state machine tests rt-agnostic #1227

Merged

Conversation

SteveLauC
Copy link
Collaborator

@SteveLauC SteveLauC commented Aug 5, 2024

What does this PR do

Based on the discussion in this thread, turning test_all() and test_store() asynchronous to make the log tests runtime-agnostic.

Checklist

  • Updated guide with pertinent info (may not always apply).
  • Squash down commits to one or two logical commits which clearly describe the work you've done.
  • Unittest is a friend:)

This change is Reviewable

@SteveLauC
Copy link
Collaborator Author

openraft/src/docs/getting_started/getting-started.md line 183 at r1 (raw file):

To test your implementation, you have two options:

1. Run `Suite::test_all()` with an `async fn()` that creates a new pair of [`RaftLogStorage`] and [`RaftStateMachine`],

impl StoreBuilder for Fn has been removed in this commit, so this approach no longer works.

@drmingdrmer drmingdrmer self-requested a review August 6, 2024 01:50
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion

@drmingdrmer drmingdrmer merged commit 801ca4d into databendlabs:main Aug 6, 2024
32 of 33 checks passed
@SteveLauC SteveLauC deleted the Test/log_test_rt_agnostic branch August 6, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants