Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetByName method does not work for Volumes #1039

Open
shreyas-goenka opened this issue Sep 9, 2024 · 1 comment
Open

GetByName method does not work for Volumes #1039

shreyas-goenka opened this issue Sep 9, 2024 · 1 comment

Comments

@shreyas-goenka
Copy link
Contributor

Description
The GetByName method calls ListVolumes which requires a catalog_name argument that's not provided by the implementation. So you end up with an error:

ListVolumes Missing required field: catalog_name

Reproduction
Example to reproduce:

func TestFoo(t *testing.T) {
	w, err := databricks.NewWorkspaceClient()
	require.NoError(t, err)

	_, err = w.Volumes.GetByName(context.Background(), "main.test-schema-1.test-volume-1")
	require.NoError(t, err)
}

Is it a regression?
The SDK version is v0.45.0. I don't think this is a regression.

@shreyas-goenka
Copy link
Contributor Author

It seems like there's a ReadByName method, which does what you'd expected the GetByName method to do. Both claim to "Get the volume" and return the same object. It's not clear why both of them exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant