Explicit propagation for json,"..,optional" fields

[nfx]

fix cases around optional propagation:

func isOptional(typeField reflect.StructField) bool {
	if strings.Contains(typeField.Tag.Get("json"), "omitempty") {
		return true
	}
	tfTags := strings.Split(typeField.Tag.Get("tf"), ",")
	for _, tag := range tfTags {
		if tag == "optional" {
			return true
		}
	}
	return false
}
...
                omitEmpty := isOptional(typeField)
		if omitEmpty && !fieldSchema.Optional {
			return fmt.Errorf("inconsistency: %s has omitempty, but is not optional", fieldName)
		}

[nfx]

Google API SDK does it through custom marshallers:

https://github.com/googleapis/google-api-go-client/blob/4dca4e00ad5b16c8a06dec1c4ae9d3b5f917406a/google-api-go-generator/gen.go#L1433-L1474

https://github.com/googleapis/google-api-go-client/blob/c58bf4cfef76fcd9a377452b5c3cb84d5f20ce98/internal/gensupport/json.go#L14-L50

example of generated ForceSendFields https://github.com/googleapis/google-api-go-client/blob/93de45545cb6714f94bc4c347e3d932519e1f36d/groupssettings/v1/groupssettings-gen.go#L712-L735

[benbauer89]

Hey, I created an issue with basically the same problem: databricks/terraform-provider-databricks#1776
any chance this gets prioritized in one of the next releases?

[nfx]

@benbauer89 we'll pick it up once we SDK-migrate TF resource that needs it

[pietern]

@hectorcast-db Is working on support for this in #615 and more.

[mgyucht]

I think the Go SDK changes are complete, so we can probably close this issue? The remaining issues stem from the TF provider and should be resolved when TF starts to use ForceSendFields (hopefully in the next release).

[hectorcast-db]

Correct. SDK changes are complete. Closing this issue.