Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] Access control list not parsed correctly #329

Closed
julianfesel opened this issue Aug 31, 2023 · 3 comments
Closed

[ISSUE] Access control list not parsed correctly #329

julianfesel opened this issue Aug 31, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@julianfesel
Copy link

julianfesel commented Aug 31, 2023

Description
Creating a new job with an access control list leads to an error:
TypeError: Object of type AccessControlRequest is not JSON serializable

It is probably because there is an ".as_dict()" missing here:

if access_control_list is not None: body['access_control_list'] = [v for v in access_control_list]

Reproduction
Using the method WorkspaceClient().jobs.create() with a list of AccessControlRequest like:

acl = [AccessControlRequest(
            user_name="funny.user@compa.ny", permission_level=PermissionLevel.CAN_MANAGE
        )]

Other Information

  • OS: macOS
  • Version: 0.7.0
@pietern
Copy link
Contributor

pietern commented Sep 6, 2023

Thanks for reporting the issue. We'll take a look.

@pietern pietern added the bug Something isn't working label Sep 6, 2023
@pspeter
Copy link

pspeter commented Sep 7, 2023

Hi Julian!
Duplicate of #270 😉

@mgyucht
Copy link
Contributor

mgyucht commented Sep 27, 2023

I'm closing this as a duplicate of #270.

@mgyucht mgyucht closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants