Gracefully handle virtual /Repos/me folder #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
==========================================
+ Coverage 82.51% 82.71% +0.19%
==========================================
Files 41 41
Lines 1510 1510
Branches 297 297
==========================================
+ Hits 1246 1249 +3
+ Misses 264 261 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fjakobs
approved these changes
May 9, 2023
Merged
fjakobs
added a commit
that referenced
this pull request
May 10, 2023
## packages/databricks-vscode ## <small>0.3.13 (2023-05-09)</small> * Gracefully handle virtual /Repos/me folder (#693) ([b1a234f](b1a234f)), closes [#693](#693) [#683](#683) [#691](#691) [#688](#688) * Update telemetry connection strings (#692) ([a5a9dbd](a5a9dbd)), closes [#692](#692) ## packages/databricks-sdk-js ## <small>0.3.13 (2023-05-09)</small> ## packages/databricks-vscode-types ## <small>0.3.13 (2023-05-09)</small> --------- Co-authored-by: releasebot <noreply@github.com> Co-authored-by: Fabian Jakobs <fabian.jakobs@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The extension tries to find the root folder (/Repos/me or /Users/me/.ide) depending on what the sync destination type is (repos or workspace). The current root is stored in
currentFsRoot. In case it fails in finding thecurrentFsRoot(/Repos/me and /Users/me can be virtual when a user hasn't interacted with these folders yet), it always tries to create it under /User/me. This can be an issue ifcurrentFsRootpoints to /Repos/me.workspaceFsRoot(which always points to /Users/me/.ide) under /User/me and notcurrentFsRoot.Creating a repo from the extension automatically handles generation of /Repos/me folder as well.
Fixes #683 #691 #688
Tests