Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintegrate functional adapter tests into GitHub Action CI #204

Closed
dataders opened this issue Oct 4, 2022 · 1 comment
Closed

Reintegrate functional adapter tests into GitHub Action CI #204

dataders opened this issue Oct 4, 2022 · 1 comment

Comments

@dataders
Copy link
Contributor

dataders commented Oct 4, 2022

I might be lost in tox here, but as far as I can tell, there are tox jobs setup to run the dbt-core's integration test suite, but I don't see them being run in a PR's CI, only the unit tests (which are incredible and very comprehensive btw!)

dbt-databricks/tox.ini

Lines 30 to 64 in e921754

[testenv:integration-databricks-cluster]
basepython = python3
commands = /bin/bash -c '{envpython} -m pytest -v --profile databricks_cluster -n4 tests/functional/adapter/* {posargs}; ret=$?; [ $ret = 5 ] && exit 0 || exit $ret'
/bin/bash -c '{envpython} -m pytest -v -m profile_databricks_cluster -n4 tests/integration/* {posargs}; ret=$?; [ $ret = 5 ] && exit 0 || exit $ret'
passenv = DBT_* PYTEST_ADDOPTS
deps =
-r{toxinidir}/dev-requirements.txt
-r{toxinidir}/requirements.txt
[testenv:integration-databricks-uc-cluster]
basepython = python3
commands = /bin/bash -c '{envpython} -m pytest -v --profile databricks_uc_cluster -n4 tests/functional/adapter/* {posargs}; ret=$?; [ $ret = 5 ] && exit 0 || exit $ret'
/bin/bash -c '{envpython} -m pytest -v -m profile_databricks_uc_cluster -n4 tests/integration/* {posargs}; ret=$?; [ $ret = 5 ] && exit 0 || exit $ret'
passenv = DBT_* PYTEST_ADDOPTS
deps =
-r{toxinidir}/dev-requirements.txt
-r{toxinidir}/requirements.txt
[testenv:integration-databricks-sql-endpoint]
basepython = python3
commands = /bin/bash -c '{envpython} -m pytest -v --profile databricks_sql_endpoint -n4 tests/functional/adapter/* {posargs}; ret=$?; [ $ret = 5 ] && exit 0 || exit $ret'
/bin/bash -c '{envpython} -m pytest -v -m profile_databricks_sql_endpoint -n4 tests/integration/* {posargs}; ret=$?; [ $ret = 5 ] && exit 0 || exit $ret'
passenv = DBT_* PYTEST_ADDOPTS
deps =
-r{toxinidir}/dev-requirements.txt
-r{toxinidir}/requirements.txt
[testenv:integration-databricks-uc-sql-endpoint]
basepython = python3
commands = /bin/bash -c '{envpython} -m pytest -v --profile databricks_uc_sql_endpoint -n4 tests/functional/adapter/* {posargs}; ret=$?; [ $ret = 5 ] && exit 0 || exit $ret'
/bin/bash -c '{envpython} -m pytest -v -m profile_databricks_uc_sql_endpoint -n4 tests/integration/* {posargs}; ret=$?; [ $ret = 5 ] && exit 0 || exit $ret'
passenv = DBT_* PYTEST_ADDOPTS
deps =
-r{toxinidir}/dev-requirements.txt
-r{toxinidir}/requirements.txt

@dataders
Copy link
Contributor Author

dataders commented Mar 8, 2023

resolved by: #274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant