Skip to content
This repository was archived by the owner on Dec 4, 2019. It is now read-only.

Clarify RandomizedSearchCV documentation for sampling with replacement #104

Open
shaunswanson opened this issue Feb 5, 2019 · 2 comments

Comments

@shaunswanson
Copy link
Contributor

At this line, it may be better to explicitly mention which parameters will be sampled with replacement if any one of them is a distribution:

https://github.com/databricks/spark-sklearn/blob/master/python/spark_sklearn/random_search.py#L27

Are all parameters (those given as distributions and those given as lists of values) sampled with replacement in this scenario, or only parameters given by distributions?

If so, this documentation would be better stated as:

sampling with replacement is used for all parameters.

@shaunswanson
Copy link
Contributor Author

Let me know if you'd like a pull request. :)

@srowen
Copy link
Collaborator

srowen commented Feb 5, 2019

Sure, yeah, I'm sure this could use some clarification. Feel free to open a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants