Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Replace ADAL auth with MSAL auth (ADAL out of support december 2022) #1588

Closed
janlunddk opened this issue Sep 9, 2022 · 1 comment
Labels
feature New feature or request

Comments

@janlunddk
Copy link

Use-cases

For a client, I am evaluating Databricks and its surrounding tools, and the Databricks Terraform provider is raising concerns.

The provider authentication method used for Azure is currently ADAL.

As ADAL will be out of support in December 2022, continuing to use it poses a security risk, as no security fixes will no longer be released.
(Ref.: https://docs.microsoft.com/en-us/azure/active-directory/develop/msal-migration)

As for the Go module auto-rest/adal, it will go out of support 31. Mar. 2023.

Ref.:
https://github.com/Azure/go-autorest/tree/main/autorest/adal
https://docs.microsoft.com/en-us/azure/developer/go/azure-sdk-authorization

Attempted Solutions

None. ADAL support will end soon and security will be compromised.

Proposal

Update the provider to use the azidentity module instead.
https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/azidentity

Migration guide:
https://github.com/Azure/azure-sdk-for-go/blob/b386adc15c2e60e3812956f68d244b608330c479/sdk/azidentity/MIGRATION.md

@nkvuong
Copy link
Contributor

nkvuong commented Apr 4, 2023

Resolved in #1848

@nkvuong nkvuong closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants