More verbose logging of termination reason #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would help with debugging in cases when cluster can't start for some reason, such as provider error. Existing debugging doesn't help because `ClusterInfo.StateMessage` doesn't include full error message
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
==========================================
+ Coverage 82.21% 82.23% +0.01%
==========================================
Files 78 78
Lines 6766 6770 +4
==========================================
+ Hits 5563 5567 +4
Misses 796 796
Partials 407 407
|
nfx
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would help with debugging in cases when cluster can't start for some reason, such as provider error. Existing debugging doesn't help because
ClusterInfo.StateMessagedoesn't include full error message