apply debug_truncate_bytes also for response dumps #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, reworked the reporting of termination information
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
- Coverage 82.23% 82.21% -0.02%
==========================================
Files 78 78
Lines 6770 6774 +4
==========================================
+ Hits 5567 5569 +2
- Misses 796 797 +1
- Partials 407 408 +1
|
nfx
reviewed
Apr 9, 2021
| "%s is not able to transition from %s to %s: %s. Please see %s for more details", | ||
| clusterID, clusterInfo.State, desired, clusterInfo.StateMessage, docLink)) | ||
| "%s is not able to transition from %s to %s: %s%s. Please see %s for more details", | ||
| clusterID, clusterInfo.State, desired, clusterInfo.StateMessage, details, docLink)) |
There was a problem hiding this comment.
this is much better to have it part of a propagated error! :)
nfx
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, reworked the reporting of termination information