Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicitly force import manually added user #1048

Merged
merged 3 commits into from
Jan 21, 2022
Merged

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Jan 19, 2022

Add force parameter to databricks_user, so that SCIM sync corner cases might be simplified

image

@nfx nfx requested a review from alexott January 19, 2022 18:00
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #1048 (4039d1f) into master (9bd9112) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1048      +/-   ##
==========================================
+ Coverage   90.80%   90.82%   +0.01%     
==========================================
  Files         109      109              
  Lines        9408     9425      +17     
==========================================
+ Hits         8543     8560      +17     
  Misses        513      513              
  Partials      352      352              
Impacted Files Coverage Δ
scim/resource_user.go 93.84% <100.00%> (+2.17%) ⬆️

@lgtm-com
Copy link

lgtm-com bot commented Jan 19, 2022

This pull request introduces 1 alert when merging 11fa663 into 9bd9112 - view on LGTM.com

new alerts:

  • 1 for Potentially unsafe quoting

@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2022

This pull request introduces 1 alert when merging 19832e1 into 9bd9112 - view on LGTM.com

new alerts:

  • 1 for Potentially unsafe quoting

@nfx nfx marked this pull request as ready for review January 20, 2022 15:00
@nfx nfx added this to the v0.4.6 milestone Jan 20, 2022
@alexott
Copy link
Contributor

alexott commented Jan 20, 2022

Should we support the same for groups? It would help when switching from SCIM connector…

Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.look good

scim/resource_user.go Outdated Show resolved Hide resolved
scim/resource_user.go Outdated Show resolved Hide resolved
scim/resource_user.go Show resolved Hide resolved
@nfx nfx merged commit da259d7 into master Jan 21, 2022
@nfx nfx deleted the user-force-implicit-import branch January 21, 2022 09:07
@nfx nfx mentioned this pull request Jan 21, 2022
100 tasks
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants