Feature/update doc #1332

nkvuong · 2022-05-24T15:28:39Z

Upgrade AWS provider for AWS guides
Add examples for account-level identities

codecov · 2022-05-24T15:33:07Z

Codecov Report

Merging #1332 (3439c66) into master (d014779) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1332   +/-   ##
=======================================
  Coverage   90.60%   90.60%           
=======================================
  Files         118      118           
  Lines       10004    10004           
=======================================
  Hits         9064     9064           
  Misses        559      559           
  Partials      381      381

docs/guides/unity-catalog.md

nfx · 2022-05-24T16:01:42Z

docs/resources/service_principal.md

-Directly manage [Service Principals](https://docs.databricks.com/administration-guide/users-groups/service-principals.html) that could be added to [databricks_group](group.md) within workspace.
+Directly manage [Service Principals](https://docs.databricks.com/administration-guide/users-groups/service-principals.html) that could be added to [databricks_group](group.md) in Databricks workspace or account.
+
+To create service principals in the Databricks account, the provider must be configured with `host = "https://accounts.azuredatabricks.net"` on AWS deployments or `host = "https://accounts.azuredatabricks.net"` and `auth_type  = "azure-cli"` on Azure deployments


is it really available for User Principals only? Is it the same SPN OBO flow issue? :(

sp can be added to the account as well

so why do we need auth_type = "azure-cli" then?

🤦 - corrected it to AAD tokens

Co-authored-by: Serge Smertin <259697+nfx@users.noreply.github.com>

…form-provider-databricks into feature/update-doc

nfx

Few last changes required

nfx · 2022-05-26T11:31:56Z

docs/resources/group.md

-This resource allows you to manage [groups in Databricks Workspace](https://docs.databricks.com/administration-guide/users-groups/groups.html) or [Account Console](https://accounts.cloud.databricks.com/) (for AWS deployments). You can also [associate](group_member.md) Databricks users and [service principals](service_principal.md) to groups. This is useful if you are using an application to sync users & groups with SCIM API.
+This resource allows you to manage [groups in Databricks Workspace](https://docs.databricks.com/administration-guide/users-groups/groups.html), [Databricks Account Console](https://accounts.cloud.databricks.com/) or [Azure Databricks Account Console](https://accounts.azuredatabricks.net). You can also [associate](group_member.md) Databricks users and [service principals](service_principal.md) to groups. This is useful if you are using an application to sync users & groups with SCIM API.
+
+To create groups in the Databricks account, the provider must be configured with `host = "https://accounts.azuredatabricks.net"` on AWS deployments or `host = "https://accounts.azuredatabricks.net"` and authenticate using AAD tokens on Azure deployments


Azure Databricks in both cases? :-)

docs/resources/group_member.md

nfx · 2022-05-26T11:33:28Z

docs/resources/group_member.md

-This resource allows you to attach [users](user.md) and [groups](group.md) as group members.
+This resource allows you to attach [users](user.md), [service_principal](service_principal.md) and [groups](group.md) as group members.
+
+To attach members to groups in the Databricks account, the provider must be configured with `host = "https://accounts.azuredatabricks.net"` on AWS deployments or `host = "https://accounts.azuredatabricks.net"` and authenticate using AAD tokens on Azure deployments


Azure Databricks in both cases?

nfx · 2022-05-26T11:33:56Z

docs/resources/service_principal.md

-Directly manage [Service Principals](https://docs.databricks.com/administration-guide/users-groups/service-principals.html) that could be added to [databricks_group](group.md) within workspace.
+Directly manage [Service Principals](https://docs.databricks.com/administration-guide/users-groups/service-principals.html) that could be added to [databricks_group](group.md) in Databricks workspace or account.
+
+To create service principals in the Databricks account, the provider must be configured with `host = "https://accounts.azuredatabricks.net"` on AWS deployments or `host = "https://accounts.azuredatabricks.net"` and authenticate using AAD tokens on Azure deployments


Both azure?

ctrl+c, ctrl+v error

nfx · 2022-05-26T11:34:26Z

docs/resources/user.md

-This resource is used to [manage users](https://docs.databricks.com/administration-guide/users-groups/users.html), that could be added to [databricks_group](group.md) within the workspace. Upon user creation the user will receive a password reset email. You can also get information about caller identity using [databricks_current_user](../data-sources/current_user.md) data source.
+This resource allows you to manage [users in Databricks Workspace](https://docs.databricks.com/administration-guide/users-groups/users.html), [Databricks Account Console](https://accounts.cloud.databricks.com/) or [Azure Databricks Account Console](https://accounts.azuredatabricks.net). You can also [associate](group_member.md) Databricks users to [databricks_group](group.md). Upon user creation the user will receive a password reset email. You can also get information about caller identity using [databricks_current_user](../data-sources/current_user.md) data source.
+
+To create users in the Databricks account, the provider must be configured with `host = "https://accounts.azuredatabricks.net"` on AWS deployments or `host = "https://accounts.azuredatabricks.net"` and authenticate using AAD tokens on Azure deployments


Both azure?)

Co-authored-by: Serge Smertin <259697+nfx@users.noreply.github.com>

…form-provider-databricks into feature/update-doc

nfx

Lgtm

## 0.5.9 * Added warning section for debug mode ([#1325](#1325)). * Added ability to specify tags for `databricks_job` ([#1337](#1337)). * Upgraded AWS provider for AWS guides. Added examples for account-level identities ([#1332](#1332)). * Updated docs to use `application_id` as privilege for `databricks_service_principal` ([#1336](#1336)). * Added `databricks_service_principal_role` resource ([#1340](#1340)). * Fixed itegration testing image ([#1342](#1342), [#1343](#1343)). * Added `skip_validation` for `databricks_external_location` ([#1330](#1330)). * Added `alert_on_last_attempt` to `databricks_job` ([#1341](#1341)). * Skip `make test` on doc-only changes ([#1339](#1339)). * Improve common package test coverage ([#1344](#1344)). * Re-create purged cluster for `databricks_mount` for AWS S3 ([#1345](#1345)). Updated dependency versions: * Bump google.golang.org/api from 0.79.0 to 0.80.0 * Bump github.com/Azure/go-autorest/autorest/adal from 0.9.19 to 0.9.20

nkvuong added 5 commits May 24, 2022 16:05

update aws provider version in guide

e2cca98

missed another provider upgrade

65fce34

fix missing link

4e5af68

add examples for account-level identities

7471e08

missing space

dcab03b

nfx reviewed May 24, 2022

View reviewed changes

nkvuong and others added 3 commits May 24, 2022 18:37

Update docs/guides/unity-catalog.md

3164d34

Co-authored-by: Serge Smertin <259697+nfx@users.noreply.github.com>

correct azure auth & add group membership

446f30a

Merge branch 'feature/update-doc' of https://github.com/nkvuong/terra…

daf9018

…form-provider-databricks into feature/update-doc

nfx requested changes May 26, 2022

View reviewed changes

nkvuong and others added 4 commits May 26, 2022 13:29

Update docs/resources/group_member.md

99357e2

Co-authored-by: Serge Smertin <259697+nfx@users.noreply.github.com>

fix wrong urls

40a27e6

Merge branch 'feature/update-doc' of https://github.com/nkvuong/terra…

f8a9753

…form-provider-databricks into feature/update-doc

another wrong url

1178188

nfx approved these changes May 26, 2022

View reviewed changes

Merge branch 'master' into feature/update-doc

3439c66

nfx merged commit 486cb1f into databricks:master May 26, 2022

nfx mentioned this pull request May 30, 2022

Release v0.5.9 #1346

Merged

nkvuong deleted the feature/update-doc branch June 10, 2022 16:19

michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023

Feature/update doc (databricks#1332)

d81eaf8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/update doc #1332

Feature/update doc #1332

nkvuong commented May 24, 2022

codecov bot commented May 24, 2022 •

edited

Loading

nfx May 24, 2022

nkvuong May 24, 2022

nfx May 24, 2022

nkvuong May 24, 2022

nfx left a comment

nfx May 26, 2022

nfx May 26, 2022

nfx May 26, 2022

nkvuong May 26, 2022

nfx May 26, 2022

nfx left a comment

Feature/update doc #1332

Feature/update doc #1332

Conversation

nkvuong commented May 24, 2022

codecov bot commented May 24, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nfx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nfx left a comment

Choose a reason for hiding this comment

codecov bot commented May 24, 2022 •

edited

Loading