resource group entitlement check fix and detecting changes fix #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
==========================================
+ Coverage 81.81% 82.15% +0.34%
==========================================
Files 78 78
Lines 6768 6771 +3
==========================================
+ Hits 5537 5563 +26
+ Misses 818 800 -18
+ Partials 413 408 -5
|
alexott
approved these changes
Mar 5, 2021
nfx
requested changes
Mar 5, 2021
|
hi @stikkireddy, do you have any updates on the test coverage? |
|
@nfx i should have some time later today and tomorrow to work on this. |
…-databricks into resource-group-changes-patch
|
@nfx everything should be up to date now with coverage of resource_group |
alexott
approved these changes
Mar 25, 2021
nfx
approved these changes
Mar 27, 2021
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
…ricks#549) * resource group entitlement check fix and detecting changes fix * updated test stub * fixed up the update tests for appropriate coverage * cover all lines in group resource but the terraform data set statements * added statement into changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entitlements for resource groups had typos and logic for detecting changes was not working correctly. This fix resolves those issues.