Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Make DependencyResolver a cached property of GlobalContext #1582

Closed
1 task done
Tracked by #1202
ericvergnaud opened this issue Apr 29, 2024 · 1 comment
Closed
1 task done
Tracked by #1202

[FEATURE]: Make DependencyResolver a cached property of GlobalContext #1582

ericvergnaud opened this issue Apr 29, 2024 · 1 comment
Labels
tech debt chores and design flaws

Comments

@ericvergnaud
Copy link
Contributor

ericvergnaud commented Apr 29, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

Currently, the DependencyResolver is instantiated directly, thus not benefiting from pre-configured instances cached in the GlobalContext

Proposed Solution

Mahe the DependencyResolver a cached property of GlobalContext

Additional Context

sub-ticket of #1202
@ericvergnaud ericvergnaud added enhancement New feature or request needs-triage labels Apr 29, 2024
@ericvergnaud ericvergnaud added this to UCX Apr 29, 2024
@github-project-automation github-project-automation bot moved this to Triage in UCX Apr 29, 2024
This was referenced Apr 29, 2024
Closed
Merged
@nfx
Copy link
Collaborator

nfx commented May 2, 2024

Solved in #1560

@nfx nfx closed this as completed May 2, 2024
@github-project-automation github-project-automation bot moved this from Triage to Archive in UCX May 2, 2024
@nfx nfx added tech debt chores and design flaws and removed enhancement New feature or request needs-triage labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt chores and design flaws
Projects
UCX
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nfx @ericvergnaud