Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm 3 compatibility? Make it clear in README #207

Closed
max-rocket-internet opened this issue Apr 22, 2020 · 3 comments
Closed

Helm 3 compatibility? Make it clear in README #207

max-rocket-internet opened this issue Apr 22, 2020 · 3 comments

Comments

@max-rocket-internet
Copy link

max-rocket-internet commented Apr 22, 2020

I understand this plugin is not compatible with Helm 3? Is that correct?

Other issues regarding Helm 3 but unclear:
#205
#180
#170

It would be good to have a loud and clear reference in the README to state whether it is or not 🙂

@deiga
Copy link
Contributor

deiga commented Apr 22, 2020

It is compatible with helm 3. If it weren't then that should be mentioned, otherwise the assumption should be that it is compatible with latest version

@deiga
Copy link
Contributor

deiga commented Apr 22, 2020

What issue are you encountering that makes you think it isn't compatible?

@max-rocket-internet
Copy link
Author

If it weren't then that should be mentioned

OK but in the README there is mentions of Helm version > 2.3.x, which I know would include version 3 but version 2.3 is sooo old, it kinda makes me think this plugin is not made for recent versions of Helm.

But OK, I will close this issue.

What issue are you encountering that makes you think it isn't compatible?

The diff is not fully shown to include reverting manual changes in the cluster. In Helm2 this didn't matter but in Helm3 it's very important due to the new 3-way merge process. It's this actually issue: #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants