Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm diff always shows a diff in the caBundle #254

Closed
lifelofranco opened this issue Dec 11, 2020 · 3 comments
Closed

Helm diff always shows a diff in the caBundle #254

lifelofranco opened this issue Dec 11, 2020 · 3 comments
Labels

Comments

@lifelofranco
Copy link

I am currently using the AWS load balancer controller helm chart. Running diff always shows a revision in the caBundle.

Screen Shot 2020-12-11 at 7 11 21 PM

@katiekeel
Copy link

I'm also having this issue, except with the letsencrypt chart, and the spec.acme.privateKeySecretRef.name value. Both strings are exactly the same, but show as a diffed line.

Screen Shot 2021-01-29 at 12 32 32 PM

@jo2y-tock
Copy link

Note: I'm not a helm diff maintainer, this is a drive by comment because I was looking to debug something else. I probably won't be able to help much more.

Technically, there is a diff in the @lifelofranco's screenshot. It starts in the first line about 2-3 dozen characters in (SURQek vs SURREN).

Looking at the referenced helm chart, a new caBundle value is generated from random data each time you run helm (See offending line and genCa function). So diff is doing the right thing. The problem seems to be more with the chart.

For @katiekeel's screenshot, I'm stumped and I didn't find a letsencrypt chart in a quick search. Usually when I see something like that happen, it's either a trailing whitespace issue that's being preserved in one place and not the other, or one or more of the letters in one is a look-a-like unicode letter. Ie. visually the same, but byte-wise different. For this, I use either careful selection with the mouse to see if a hidden space is there, or pipe it to od -a to see what I get.

Note the 'sp' in the second one.

% echo foo | od -a
0000000    f   o   o  nl
0000004 
% echo foo\ | od -a
0000000    f   o   o  sp  nl
0000005

@stale
Copy link

stale bot commented Jun 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 18, 2021
@stale stale bot closed this as completed Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants