Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff is incorrect when values in values.yaml change and using local Chart #464

Open
cbugneac-nex opened this issue Jun 5, 2023 · 0 comments

Comments

@cbugneac-nex
Copy link

cbugneac-nex commented Jun 5, 2023

I have a local Chart in the ingress-class directory which is deployed to K8s cluster:

.
├── ingress-class
│   ├── Chart.yaml
│   ├── templates
│   │   ├── ingress-class-params.yaml
│   │   └── ingress-class.yaml
│   └── values.yaml

values.yaml

inboundCIDRs:
  - "1.1.1.1/32"     # Test VPN1
  - "2.2.2.2/32"     # Test VPN2

If I make a change to the values.yaml file by adding new IPs, the diff doesn't show any updates:

helm diff upgrade ingress-class ingress-class/ --allow-unreleased

My expectation is that helm diff should look for updated values file in Helm chart directory but it doesn't.

But if I include the path to values file explicitly, it works:

helm diff upgrade --allow-unreleased -f ingress-class/values.yaml ingress-class ingress-class/
default, external, IngressClassParams (elbv2.k8s.aws) has changed:
  # Source: ingress-class/templates/ingress-class-params.yaml
  apiVersion: elbv2.k8s.aws/v1beta1
  kind: IngressClassParams
  metadata:
    name: external
  spec:
    scheme: internet-facing
    group:
      name: external
    inboundCIDRs:
      - 1.1.1.1/32
      - 2.2.2.2/32
+     - 3.3.3.3/32
+     - 4.4.4.4/32
$ helm plugin list
NAME	VERSION	DESCRIPTION
diff	3.8.1  	Preview helm upgrade changes as a diff

$ helm version
version.BuildInfo{Version:"v3.12.0", GitCommit:"c9f554d75773799f72ceef38c51210f1842a1dea", GitTreeState:"clean", GoVersion:"go1.20.4"}

$ sw_vers
ProductName:		macOS
ProductVersion:		13.4
BuildVersion:		22F66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant