Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow has_equal_ast to work, even if no solution_ast #17

Open
machow opened this issue Nov 22, 2017 · 0 comments
Open

allow has_equal_ast to work, even if no solution_ast #17

machow opened this issue Nov 22, 2017 · 0 comments

Comments

@machow
Copy link
Contributor

machow commented Nov 22, 2017

Currently, when there's an AST misparse, then ast based SCTs are quietly skipped. This was done since we can't guarantee that for every parser will handle all student submissions handed to it. However, has_equal_ast can be adapted to work without a solution ast.

(In general, it is not clear if checking the submission and solution in an SCT is beneficial--if people will be using the exercise validator)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants