Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Enter vs Return; demonstrate edit functionality in text facet #88

Open
Talishask opened this issue Mar 22, 2021 · 2 comments
Open
Labels
type:clarification Suggest change for make lesson clearer type:enhancement Propose enhancement to the lesson

Comments

@Talishask
Copy link

I'm a member of The Carpentries staff and I'm submitting this issue on behalf of another member of the community. In most cases, I won't be able to follow up or provide more details other than what I'm providing below.


I would like to make a few suggestions to an existing lesson as part of my checkout process. The suggestions are rather small but something to consider potentially.

  1. Replace the use of "hit return" to either "hit enter" or "hit return/enter" the use of this key varies by computer mac/pc but could be confusing to users who do not have a return key.

  2. Facet edit https://datacarpentry.org/openrefine-socialsci/02-working-with-openrefine/index.html

Here we will use faceting to look for potential errors in data entry in the village column.

  1. Scroll over to the village column.
  2. Click the down arrow and choose Facet > Text facet.
  3. In the left panel, you'll now see a box containing every unique value in the village column along with a number representing how many times that value occurs in the column.
  4. Try sorting this facet by name and by count. Do you notice any problems with the data? What are they?
  5. Hover the mouse over one of the names in the Facet list. You should see that you have an edit function available.
  6. You could use this to fix an error immediately, and OpenRefine will ask whether you want to make the same correction to every value it finds like that one. But OpenRefine offers even better ways to find and fix these errors, which we'll use instead. We'll learn about these when we talk about clustering.

My suggestion would be to show learners how to make an edit here as well as "the even better way". Simply correcting one of the spelling errors in the variable list would add maybe 10 seconds to the lesson and provide additional context.

@bencomp
Copy link
Contributor

bencomp commented Nov 22, 2021

These are good suggestions.

To the first point: the lesson style guide says

We use “Return” instead of “Enter”.

However, since OpenRefine uses "Enter" in many places within the user interface, I agree that this could be confusing. Would adding a note in the Introduction be good enough?

To the second point: I agree that explaining how you could do something, but then not doing it, may be confusing. We should make sure that any edit here does not make the clustering exercise superfluous.

Note: I found that OpenRefine does record changing values from a facet as "mass-editing cells" in the history, whereas it doesn't when you change a single value in a cell.

@bencomp bencomp added type:clarification Suggest change for make lesson clearer type:enhancement Propose enhancement to the lesson labels Nov 22, 2021
@bencomp bencomp changed the title Lesson Contribution - Clarity & Village Column Clarify Enter vs Return; demonstrate edit functionality in text facet Nov 22, 2021
@bencomp
Copy link
Contributor

bencomp commented Aug 5, 2022

Regarding demonstrating changing a value in the text facet: it helps to have a messier dataset, so that we can demonstrate this for one value, and use clustering to fix the others. See #108 for suggestions to make the dataset messier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:clarification Suggest change for make lesson clearer type:enhancement Propose enhancement to the lesson
Projects
None yet
Development

No branches or pull requests

2 participants