Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with episode 13 #171

Open
fnattino opened this issue Dec 14, 2021 · 2 comments
Open

Issues with episode 13 #171

fnattino opened this issue Dec 14, 2021 · 2 comments

Comments

@fnattino
Copy link

Thanks a lot to the maintainers for this really nice lesson! Just want to point out some issues in the Episode 13 ("Plotting in Python"), probably arising from the resolution of some rebase/merge conflicts.

For example:

  • text appears twice (e.g. the paragraph "The Matplotlib library can be imported using" appears both in the first and second last section);
  • the second-last section has two headers ("Fine-tuning figures with Matplotlib" and "Customising our plots with Matplotlib");
  • the first exercise has two "Solution" boxes (the first one of which corresponds to a different exercise);
  • I believe that the first example & exercise in the second-last section should be removed?
@annajiat
Copy link
Collaborator

Thank you @fnattino for pointing out the issues.
Could you please elaborate on the 4th point?
Would you like to submit a PR for the first three points?

@gra-w
Copy link

gra-w commented Mar 15, 2022

The Episode 13 lesson on Data visualisation using Matplotlib is a great lesson with guided examples and practice! Similar to @fnattino, I noted the same text reappearing twice and the repeating headers.

Additionally, in the last section of "Customising our plots with Matplotlib" some graphs seem to be missing. The plt.show() in both the example and the solution of the section is not showing the scatterplot graphs. But I saw that the lesson has specified %matplotlib inline so technically the graphs should be showing up?

Lastly, for part of the customisation for Matplotlib, maybe we can add two brief lines that also touch on how to change the axes tick features? Something like this:

# Add some tick features
plt.yticks(np.arange(-1, 2, step=0.5))                       # Set label locations
plt.xticks([-0.25, 0.5, 1.25], ['Low', 'Medium', 'High'])    # Set and rename text labels

However, I understand that there are already a lot of comprehensive materials, so this is just a small additional suggestion!
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants