Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support omniauth-oauth2 1.4.0 #6

Closed
yob opened this issue Jun 9, 2016 · 4 comments
Closed

Support omniauth-oauth2 1.4.0 #6

yob opened this issue Jun 9, 2016 · 4 comments

Comments

@yob
Copy link
Contributor

yob commented Jun 9, 2016

I can see that in #1, this gem was changed to require omniauth-oauth2 1.3.1.

Since the breaking change in omniauth-oauth2 1.4.0 was released, it seems the omniauth-facebook and omniauth-google-oauth2 gems have released updates that continue to work.

The fix for omniauth-facebook looks like it wasn't too complicated - is there any chance the fix for this gem will be as simple?
@mfenner
Copy link
Contributor

mfenner commented Jun 9, 2016 •
edited
Loading

See pull request #7 by @eleanorakh that I just merged. Will do a new release with the changes soon, until then use the master branch.

@yob
Copy link
Contributor Author

yob commented Jun 11, 2016

Thanks!

@yob
Copy link
Contributor Author

yob commented Aug 11, 2016

Hi - just checking in on this. Are there any plans for a new release?

@mfenner
Copy link
Contributor

mfenner commented Sep 4, 2016

omniauth-oauth2 1.4.0 is now supported in omniauth-orcid 1.2.x.

@mfenner mfenner closed this as completed Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yob @mfenner