Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut, copy, paste, delete, split and merge #13

Open
colinjbrown opened this issue May 3, 2024 · 0 comments
Open

Cut, copy, paste, delete, split and merge #13

colinjbrown opened this issue May 3, 2024 · 0 comments
Labels
Backlog Higher priority than minor bug Something isn't working enhancement New feature or request

Comments

@colinjbrown
Copy link
Member

Please see:

dataflownb/dfkernel#20

As things are moved to the notebook extension we should make sure that all of these are handled properly


    Cut+Paste: retain original ids
    Copy+Paste: assign new ids and remap cell references for cells that were copied
    Delete: works as before, might attempt to flag cells the depended on the deleted cell
    Split: bottom cell retains the original id, issue will be that chaining the cells will not work so best practice is to avoid this
    Merge: retain the cell id of the last cell; since order doesn't matter in dataflows, this operation could be problematic

Note that we could try to be more proactive with split and merge. For split, we could add an extra line at the beginning of the bottom cell that references the top cell, and for merge, we could remap cell references in merged cells to local variable references. However, this could introduce issues with what users expect.```
@colinjbrown colinjbrown added bug Something isn't working enhancement New feature or request Backlog Higher priority than minor labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog Higher priority than minor bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant