-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hash] Wrap/Rewrite ClickHouse hash method for Datafuse concat_row_to_one_key #754
Comments
Related #520 |
The hashs function seems to be at: https://github.com/ClickHouse/ClickHouse/blob/master/src/Common/HashTable/Hash.h FYI, there are some related Rust implementations: MurmurHash:
CRC32:
|
@PsiACE
How to fast the group key hash: |
Thanks for your further explanation. like this apache/arrow#10290 ? |
I have an example here, which may be helpful. |
Suggested reference
|
Thanks for the reference, but it looks no help here. |
It's already done. |
ClickHouse hash faster enough, it's interesting to try to wrap it for datafuse, or rewrite them in Rust.
In datafuse, for groupby, the main performance killer is
concat_row_to_one_key
in datablock:https://github.com/datafuselabs/datafuse/blob/04f0b38f172e5aeb9580095c66124011c08ad7e0/common/datablocks/src/kernels/data_block_groupby.rs#L72-L74
concat_row_to_one_key concat all the group key by bytes to one.
ClickHouse hash methods:
https://github.com/ClickHouse/ClickHouse/blob/27ddf78ba572b893cb5351541f566d1080d8a9c6/src/Interpreters/Aggregator.h#L68-L103
The text was updated successfully, but these errors were encountered: