-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cosine_distance for vector similarity compute #10737
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mergify
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
Mar 23, 2023
BohuTANG
force-pushed
the
dev-vector-distance
branch
from
March 23, 2023 14:41
b2454e6
to
6232259
Compare
@mergify update |
☑️ Nothing to do
|
@mergify update |
✅ Branch has been successfully updated |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
This pull request introduces a new
cosine_distance
function, which takes two input vectors, from and to, represented as slices of f32 values.The function calculates the cosine distance between the two vectors and returns a Result type. If the input vectors have unequal lengths, the function returns an Err variant with an InvalidArgument error code, indicating that the lengths are not equal.
The implementation utilizes the ArrayView type from the
ndarray
library for efficient calculations.Part #10689