Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data type): ArrayType support inner dataType #5049

Merged
merged 1 commit into from
May 8, 2022

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Apr 25, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

ArrayType support inner dataType

Changelog

  • New Feature
  • Build/Testing/CI
  • Documentation

Related Issues

Fixes #4974

@vercel
Copy link

vercel bot commented Apr 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) May 7, 2022 at 1:15PM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added pr-feature this PR introduces a new feature to the codebase pr-build this PR changes build/testing/ci steps pr-doc-fix labels Apr 25, 2022
@b41sh b41sh force-pushed the array-type branch 5 times, most recently from 41186a4 to 1eabcfa Compare May 7, 2022 03:31

select * from t12;

select '==Array(String) Nullable==';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't accept Array(String null), so tests should be covered about this type.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CREATE TABLE IF NOT EXISTS t16(id Int, arr Array(String Null)) Engine = Memory; -- {ErrorCode 1005}

will parse error, we can't test this case in the stateless test.

@b41sh b41sh marked this pull request as ready for review May 7, 2022 03:57
@b41sh b41sh requested a review from BohuTANG as a code owner May 7, 2022 03:57
@sundy-li
Copy link
Member

sundy-li commented May 7, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented May 7, 2022

update

✅ Branch has been successfully updated

@BohuTANG
Copy link
Member

BohuTANG commented May 7, 2022

Oops, CI failure:

--- /workspace/tests/suites/0_stateless/03_dml/03_0023_insert_into_array.result	2022-05-07 07:40:38.903043700 +0000
+++ /workspace/tests/suites/0_stateless/03_dml/03_0023_insert_into_array.stdout	2022-05-07 07:46:59.932615348 +0000
@@ -1,3 +1,4 @@
+ERROR 1105 (HY000) at line 129: Code: 1005, displayText = sql parser error: Expected ), found: Null.
 ==Array(UInt8)==
 1	[1, 2, 3]
 2	[254, 255]

https://github.com/datafuselabs/databend/runs/6333086848?check_suite_focus=true#step:3:437

@sundy-li sundy-li requested review from Veeupup and zhang2014 May 7, 2022 22:31
@sundy-li
Copy link
Member

sundy-li commented May 7, 2022

Impressive Pr, this may be a conflict with #5167, cc @zhang2014

After merging it, retention function should use the Array<UInt8> return_type, @fkuner

@BohuTANG BohuTANG mentioned this pull request May 12, 2022
55 tasks
@Xuanwo Xuanwo added this to the v0.8 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-build this PR changes build/testing/ci steps pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Merge VariantArrayType into ArrayType
5 participants