Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): input format TSV should not use quote for enclosing #6673

Merged
merged 12 commits into from
Jul 19, 2022

Conversation

youngsofun
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

not work for clickhouse httphandler: #6669

Fixes #6554
#6553
#6650
#6650

@vercel
Copy link

vercel bot commented Jul 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jul 19, 2022 at 9:52AM (UTC)

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jul 18, 2022
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, please make Clippy happy~

tests/suites/1_stateful/00_copy_v2/00_0000_copy_tsv.result Outdated Show resolved Hide resolved
@youngsofun
Copy link
Member Author

youngsofun commented Jul 19, 2022

@Xuanwo only copy from ontime_200.csv.zst fail, is there anything special about zstd?


my fault, fixed

@youngsofun
Copy link
Member Author

log error like this

tests/suites/1_stateful/00_copy_v2/00_0000_copy_from_stage2.py

 1 | CREATE TABLE ontime200
   | ------ while parsing `CREATE TABLE [IF NOT EXISTS] [<database>.]<table> [<source>] [<table_options>]`
   .
35 |     DepDelayMinutes                 INT,
36 |     DepDel15                        INT,
37 |     DepartureDelayGroups            VARCHAR,
38 |     DepTimeBlk                      V    DepTimeBlk                              INT,
   |     ----------                      ^
   |     |                               |
   |     |                               expected `BOOLEAN`, `BOOL`, `UINT8`, `TINYINT`, `UINT16`, `SMALLINT`, or 25 more ...
   |     |                               while parsing type name
   |     while parsing `<column name> <type> [NOT NULL | NULL] [DEFAULT <default value>] [COMMENT '<comment>']`


@BohuTANG
Copy link
Member

Diff in /workspace/query/src/pipelines/processors/sources/file_splitter.rs at line 99:
         rows_to_skip: &mut u64,
     ) -> Result<()> {
         if data.is_empty() {
-            return Ok(())
+            return Ok(());
         }
         let mut data_slice = data;
Error: Process completed with exit code 1.

@Xuanwo Xuanwo changed the title fix(query): input format TSV should not use quote for enclosing. fix(query): input format TSV should not use quote for enclosing Jul 19, 2022
@mergify mergify bot merged commit 61893d0 into databendlabs:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'1046: Cannot parse value:Ok("5632622125792883430") to number type, cause: Overflow(5)' on loading hits data
4 participants