Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[store] service graceful shutdown #1186

Closed
BohuTANG opened this issue Jul 26, 2021 · 0 comments
Closed

[store] service graceful shutdown #1186

BohuTANG opened this issue Jul 26, 2021 · 0 comments
Assignees
@drmingdrmer
Labels
C-improvement Category: improvement

Comments

@BohuTANG
Copy link
Member

Summary

Make the fuse-store service graceful shutdown like fuse-query
@BohuTANG BohuTANG added the C-improvement Category: improvement label Jul 26, 2021
@BohuTANG BohuTANG added this to the v0.5 milestone Jul 26, 2021
@BohuTANG BohuTANG mentioned this issue Jul 26, 2021
Closed
drmingdrmer added a commit to drmingdrmer/databend that referenced this issue Aug 4, 2021
@drmingdrmer
[store] feature: fuse-store support restart
3f63ce9 
- Feature: support 3 server startup mode:
  For production:
    - `fuse-store --boot true`: initialized a store server and init a cluster of only 1 node.
    - `fuse-store`: start an initialized fuse-store.

  For testing:
    - `fuse-store --single true`: testing mode: open an initialized fuse store or create a new one. Most single-store test should use this mode.

  Most unittests run in `single` mode.

  Fix: databendlabs#1134

- Test: test restarting a fuse-store.
  When testing, a fuse-store should not try to boot an already booted
  node.

- Fix: potential corruption in test: holds TempDir guard.

- Feature: StoreServer::start spawns another task to serve.

- Feature: Stop a StoreServer by sending a message to a channel. Part of databendlabs#1186

- Refactor: internal: add several `open_create()` method to `MetaNode`,
  `MetaStore` etc, to support 3 startup mode: open, create and
  create-if-can-not-open.
@drmingdrmer drmingdrmer mentioned this issue Aug 4, 2021
Merged
@drmingdrmer drmingdrmer self-assigned this Aug 4, 2021
@BohuTANG BohuTANG removed this from the v0.5 milestone Oct 29, 2021
@BohuTANG BohuTANG closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drmingdrmer drmingdrmer

Labels
C-improvement Category: improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drmingdrmer @BohuTANG