Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create / add duckdb metadata functions #148

Closed
matthewmturner opened this issue Sep 16, 2024 · 5 comments · Fixed by #201
Closed

Create / add duckdb metadata functions #148

matthewmturner opened this issue Sep 16, 2024 · 5 comments · Fixed by #201

Comments

@matthewmturner
Copy link
Collaborator

matthewmturner commented Sep 16, 2024

Idea is to implement these metadata capabilities from duckdb

          I suggest we file a second ticket for implementing parquet_metadata and other duckdb metadata functions

Originally posted by @alamb in #125 (comment)

Here is parquet_metadata implementation in datafusion-cli:

Implementation is here: https://github.com/apache/datafusion/blob/257e1409eca81cfff024ecc5e2567e9f67e6b5a3/datafusion-cli/src/functions.rs#L317-L459

I would like to suggest creating those functions in their own crate (perhaps datafusion-functions-parquet?) -- it could be in the datafusion-dft repo initially for convenience, but I think eventually the goal should be that dft just be focused on integration rather than actually implementing such features.

@matthewmturner says:

i agree with putting it in its own crate. like @alamb said i also think that dft could be used as an incubator of sorts. For example I have taken that approach in my WASM function factory PR. I have no intention of keeping that in this repo but its quite convenient for the time while it matures.

@alamb
Copy link
Contributor

alamb commented Sep 16, 2024

Updated the description a littlre

@devanbenz
Copy link

take

@matthewmturner
Copy link
Collaborator Author

Cross posting here as it relates to duckdb functions apache/datafusion#12254

@matthewmturner
Copy link
Collaborator Author

hi @devanbenz just checking in on this - do you think youll have time to work on this? if not i can pick it up.

@matthewmturner
Copy link
Collaborator Author

i have started work on this

@matthewmturner matthewmturner linked a pull request Oct 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants