GMS logs elasticsearch basic auth credentials straight to the console

[martimors]

Describe the bug
When using basicauth, and the request fails (in this case because it does not expect a port), GMS (and the elasticsearch setup job too) logs the credentials to the console, like so:

2021/07/22 15:14:44 Problem with request: Get https://myuser:mypassword@mydomain.eu-central-1.es.amazonaws.com:9200: dial tcp 00.11.22.33:9200: i/o timeout. Sleeping 1s

To Reproduce
Steps to reproduce the behavior:

1. Start GMS pointed at elasticsearch with basic auth, but use the wrong uri
2. Observe password in logs

Expected behavior
I think it should either mask the password or not log the uri at all.

[jjoyce0510]

Hi @dingobar. Thanks for reporting.

Agree this is concerning. We are triaging this on our side. Will report back soon.

Thanks
John

cc. @dexter-mh-lee

[claudio-benfatto]

I opened this PR: #3241 to solve this issue for the elasticsearch-setup container. I think that similar changes to the gms container start script had already mitigated it in the gms case.

[anshbansal]

Should be fixed now. If still an issue please open a new issue.