Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset sizes in search results are not using info from filemanager #164

Open
anuveyatsu opened this issue Jan 8, 2018 · 3 comments
Open
Assignees
Milestone

Comments

@anuveyatsu
Copy link
Collaborator

If I visit http://datahub.io/search or any publisher page, eg, http://datahub.io/core, dataset size information in the list is from metastore. We need to check if that information is useful, if it is not then we should use size information from Filemanager. However, requesting size information for number of datasets might overload API (?) because we need to request data for each dataset separately. On publisher page it might be 50 API requests.

@anuveyatsu anuveyatsu added this to the Sprint - 15 Jan 2018 milestone Jan 8, 2018
@anuveyatsu anuveyatsu self-assigned this Jan 8, 2018
@anuveyatsu
Copy link
Collaborator Author

@akariv can you suggest what should we do here? Requesting size info for each dataset doesn't sound good.

@anuveyatsu
Copy link
Collaborator Author

@akariv @zelima I suggest closing this issue as WONTFIX as I'm not sure that making lots of api requests is a good solution

@zelima
Copy link
Contributor

zelima commented Mar 20, 2018

@anuveyatsu maybe we should remove size info at all as a solution here, WDYT?
Also, what is the reason they do not match?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants