Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add procedure to configure non-annexing of docker metadata #204

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

add procedure to configure non-annexing of docker metadata #204

wants to merge 2 commits into from

Conversation

bpinsard
Copy link

resolves #197

@codeclimate
Copy link

codeclimate bot commented Mar 14, 2023 •
edited
Loading

Code Climate has analyzed commit c1ffe67 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 14, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (c3bb747) 93.82% compared to head (c1ffe67) 93.90%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   93.82%   93.90%   +0.07%     
==========================================
  Files          19       19              
  Lines         956      968      +12     
==========================================
+ Hits          897      909      +12     
  Misses         59       59

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

yarikoptic
yarikoptic requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if cfg_containers wouldn't be too broad/non-specific, this specific to docker manifests right? so smth more like cfg_dockermanifests2git (I know - mouth full).

But then I wonder why I didn't ask why you just don't use generic cfg_text2git? may be that would obliterate the need for the PR as well?

and as with anything else we would need some basic unittest, can see e.g. https://github.com/datalad/datalad/blob/HEAD/datalad/local/tests/test_run_procedure.py#L350 for an example

datalad_container/resources/procedures/cfg_containers.py Outdated Show resolved Hide resolved
@bpinsard @yarikoptic
Update datalad_container/resources/procedures/cfg_containers.py
c1ffe67 
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
@bpinsard bpinsard mentioned this pull request Mar 22, 2023
Open
@yarikoptic
Copy link
Member

I will move it to Draft. I guess we should decide first on how/if to proceed with this, or just rely on cfg_text2git may be.

@yarikoptic yarikoptic marked this pull request as draft May 25, 2023 16:34
@adswa
Copy link
Member

adswa commented Sep 11, 2023

I think the issue this PR fixes is quite important to fix. Is there anything I can do to help?

@adswa
Copy link
Member

adswa commented Sep 11, 2023

But then I wonder why I didn't ask why you just don't use generic cfg_text2git? may be that would obliterate the need for the PR as well?

I would say that cfg_text2git goes too far. It alters much more dataset behavior than would be required to hangle containers. We quite often see cases where text2git configurations cause trouble when used without consideration for the specific usecase, recent examples were for example behavioral logfiles that were supposed to stay private (thus annexed), or a case in which gigantic textfiles were generated and placed to Git which eventually caused Git to revolt.

I wonder if cfg_containers wouldn't be too broad/non-specific, this specific to docker manifests right? so smth more like cfg_dockermanifests2git (I know - mouth full).

I agree that it would be useful to extend this configuration to also work with singularity images (which would be placed in .datalad/environments/<name>/image. I'm not too familiar with the docker setup, but if there is a glob that could match both of them, I'd be in favor. Then the name cfg_containers would also be very fitting IMHO

@mih mih mentioned this pull request Oct 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gitattributes to not annex docker metadata
3 participants
@bpinsard @yarikoptic @adswa