OPT: Faster approach to GitRepo.get_hexsha() #4806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## maint #4806 +/- ##
==========================================
- Coverage 89.67% 89.62% -0.05%
==========================================
Files 288 288
Lines 40352 40356 +4
==========================================
- Hits 36184 36168 -16
- Misses 4168 4188 +20
Continue to review full report at Codecov.
|
kyleam
reviewed
Aug 6, 2020
datalad/support/gitrepo.py
Outdated
| # use --quiet because the 'Needed a single revision' error message | ||
| # that is the result of running this in a repo with no commits | ||
| # isn't useful to report | ||
| cmd = ['rev-parse', '--verify', '{}^{{commit}}'.format( |
There was a problem hiding this comment.
The comment above mentions --quiet, but it's not passed here.
The previous `git-show` can be slow with more complex commits (e.g. octopus merge commit, see datalad#4801) Switch to `git-rev-parse` instead as suggested by @kyleam in datalad#4801 (comment) Behavior of `GitRepo.get_hexsha()` should stay constant for all observed usage patterns. In particular raising a ValueError when querying for a specific, but non existent commitish is critical for subdataset handling. Fixes dataladgh-4801
kyleam
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
git-showcan be slow with more complex commits (e.g.octopus merge commit, see
#4801)
Switch to
git-rev-parseinstead as suggested by @kyleam in#4801 (comment)
Behavior of
GitRepo.get_hexsha()should stay constant for allobserved usage patterns. In particular raising a ValueError when
querying for a specific, but non existent commitish is critical
for subdataset handling.
Fixes gh-4801
I will tackle an analog change (using
git-log) inGitRepo.format_commit()in a separate PR.