-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to extend to a new model? #223
Comments
Hi @billdenney, those are all really good questions. The truth is development has majorly stalled on this because I just don't really have the motivation to keep up with it anymore (switching careers has something to do with that, but general burnout is a larger factor). I had talked with @JaySumners about even taking over as maintainer, but he is the main person that has really thought through extensibility. The short answer is it's not very extensible now, and we had hoped to make it more so, but never actually got around to it. Sorry if that's a disappointing response, but perhaps Jay will have more context or more info for you. Also happy to talk about PRs if you'd like to take on something on your own. And yes, we could definitely export any of the functions that are currently internal if they are helpful. |
@datalorax , sorry to hear about the burnout feeling. Are you considering transitioning the package to @JaySumners for maintenance? I think that the package is useful. If neither of you have time for maintaining and extending it, have you considered seeing if ropensci would be interested in taking over development? |
That's not a bad idea. I'm not sure I'm ready to do that yet, but it's definitely worth considering. |
I wasn't intending it to be a push-- it is intended as a brainstorm. (Tone is hard by both email and github issues. 😄 ) |
Yeah no worries, I didn't intend it as pushing. I genuinely appreciate the thought! |
Related to #177
I'm looking to use
extract_eq()
to help with thenlmixr2
package. It typically uses nonlinear, mixed-effect models that are defined by multiple equations.For that, I was looking at several items of how this is working and I have a few questions and thoughts:
nlmixr2
models, many of the arguments forextract_eq()
don't apply. As part of Refectoring for Extensibility #177, have you considered having the generic as something much simpler likeextract_eq <- function(model, ...) {UseMethod("extract_eq")}
?escape_tex()
function? Are there other internal helper functions that may be necessary for generating high-quality outputs?The text was updated successfully, but these errors were encountered: