Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review generic LotR zones #5

Open
datanoh opened this issue Sep 19, 2024 · 0 comments
Open

Review generic LotR zones #5

datanoh opened this issue Sep 19, 2024 · 0 comments
Labels
Java removing LotR Removing LotR-specific code from ours

Comments

@datanoh
Copy link
Owner

datanoh commented Sep 19, 2024

The Zone enum in Zone.java includes 6 classes from LotR that I'm not certain are well-integrated in the ST:CCG code or not:

  • Support
  • Attached
  • Stacked
  • Removed
  • Void
  • Void from Hand

Recommend looking into these classes and identifying if they are needed for ST:CCG. If so, recommend documentation to explain what they are and how they should be used consistently.
@datanoh datanoh added removing LotR Removing LotR-specific code from ours Java labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Java removing LotR Removing LotR-specific code from ours
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@datanoh