Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added editor page #106

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Added editor page #106

merged 2 commits into from
Feb 4, 2022

Conversation

NicolasMarqui
Copy link
Contributor

Adding where i'm up to with the editor page

** The page can be seen under /editor/123 ** (123 as in the pipelineId)
editor4

Todo

Need to fix filemanager background color when on dark mode
editor_dark

Need to find a better way to integrate the file manager with monaco. The manager only returns an ID from the file...so i'm assuming we gonna have an extra query to fetch the file content, corrrect?

Need to format the editor on file change.

(the basic integration can be seen when clicking on the 'hello-world.js' file at the bottom of the file manager)

return
(the response from the file manager)

@saul-data saul-data merged commit 6416791 into dataplane-app:main Feb 4, 2022
@NicolasMarqui NicolasMarqui deleted the editorPage branch February 23, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants