Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global.tls.functionsWorker.enabled is ignored #123

Closed
pgier opened this issue Aug 1, 2023 · 4 comments
Closed

global.tls.functionsWorker.enabled is ignored #123

pgier opened this issue Aug 1, 2023 · 4 comments

Comments

@pgier
Copy link
Collaborator

pgier commented Aug 1, 2023

The functionsWorker tls setting seems to be ignored. When I have tls enabled globally, but disabled on the functionsWorker, then the functionsWorker still gets TLS settings activated.

  global:
    tls:
      enabled: true
      functionsWorker:
        enabled: false
@dave2wave
Copy link

Please feel free to comment on the work with #110 and if something else is needed in that fix.

@nicoloboschi
Copy link
Contributor

@pgier what are the TLS settings that you should expect to be disabled ?

@pgier
Copy link
Collaborator Author

pgier commented Aug 23, 2023

@nicoloboschi The documentation isn't that clear about the behavior of the global.tls.enabled setting. It seems that this is a global override and not a global default. I think if we can clarify this in the docs, then we can close this issue.
See also #136

@pgier
Copy link
Collaborator Author

pgier commented Aug 24, 2023

I think the confusion here was that enabling TLS on the broker causes the functionsWorker to also require mounting the TLS certificate. I'm going to close this one because it should be resolved by #135

@pgier pgier closed this as completed Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants