Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] add multi MySQL server version to CatalogMysqlIT Integrate test to improve compatibility #1367

Closed
Tracked by #1335
FANNG1 opened this issue Jan 8, 2024 · 4 comments · Fixed by #1682
Closed
Tracked by #1335

[Improvement] add multi MySQL server version to CatalogMysqlIT Integrate test to improve compatibility #1367

FANNG1 opened this issue Jan 8, 2024 · 4 comments · Fixed by #1682
Assignees
@Clearvive
Labels
good first issue Good for newcomers improvement Improvements on everything
Milestone
Gravitino 0.4.0

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented Jan 8, 2024

What would you like to be improved?

CatalogMysqlIT testing MySQL with mysql:8.0, we'd better add mysql:5.7

How should we improve?

No response
@FANNG1 FANNG1 added the improvement Improvements on everything label Jan 8, 2024
@FANNG1 FANNG1 mentioned this issue Jan 8, 2024
Closed
12 tasks
@FANNG1 FANNG1 added the good first issue Good for newcomers label Jan 9, 2024
@kumarav1nash
Copy link

Hi, I want to take this issue,

@FANNG1, can you help run the server, I'm using this cmd ./bin/gravitino.sh start but it's not working, am I missing some configuration

@FANNG1
Copy link
Contributor Author

FANNG1 commented Jan 9, 2024 •
edited
Loading

thanks for taking this issue， you can refer https://datastrato.ai/docs/0.3.0/how-to-install/ to how to start GravitinoServer, you could check logs in logs directory, please note that if you deploy Gravitino by ./gradlew compileDistribution, you should goto distribution/package directory to start Gravitino

@jerryshao jerryshao added this to the Gravitino 0.4.0 milestone Jan 16, 2024
@FANNG1 FANNG1 mentioned this issue Jan 24, 2024
Merged
jerryshao pushed a commit that referenced this issue Jan 24, 2024
@FANNG1
[#1367] test(mysql-jdbc): add mysql 5.7 to integerate IT (#1682)
411e8b9 
### What changes were proposed in this pull request?
add mysql 5.7 to  integerate IT

### Why are the changes needed?
junit5 doesn't support class level ParameterizedTest,
junit-team/junit5#878 . so use a separate
class.

Fix: #1367

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
integrate test
@FANNG1
Copy link
Contributor Author

FANNG1 commented Jan 24, 2024

Hi, @kumarav1nash this issue is expected to be fixed in 0.4 in this week, so I fixed it.

@kumarav1nash
Copy link

Thanks @FANNG1, from last two weeks i was occupied with my org release cycle so did not get the chance to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Clearvive Clearvive

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.4.0
Development

Successfully merging a pull request may close this issue.

[#1367] test(mysql-jdbc): add mysql 5.7 to integerate IT FANNG1/gravitino
4 participants
@jerryshao @FANNG1 @kumarav1nash @Clearvive