Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] When calling hash() function in name_identifier with python client throw an exception #3521

Closed
xloya opened this issue May 23, 2024 · 0 comments · Fixed by #3522
Closed

[Bug report] When calling hash() function in name_identifier with python client throw an exception #3521

xloya opened this issue May 23, 2024 · 0 comments · Fixed by #3522
Assignees
@xloya
Labels
0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 bug Something isn't working

Comments

@xloya
Copy link
Collaborator

xloya commented May 23, 2024

Version

main branch

Describe what's wrong

When python needs to call the hash() method of name_identifier, a TypeError: hash() takes exactly one argument (2 given) exception will be thrown.

Error message and/or stacktrace

image

How to reproduce

Storing keys as name_identifier objects in some collection types in python, such as Dict.

Additional context

No response
@xloya xloya added the bug Something isn't working label May 23, 2024
@xloya xloya mentioned this issue May 23, 2024
Merged
jerryshao pushed a commit that referenced this issue May 23, 2024
@xloya
[#3521] fix(client-python): Fix hash() function with multiple varia…
1bb5f62 
…bles issue in `name_identitifer` (#3522)

### What changes were proposed in this pull request?

Fix `hash()` function in `name_identifier`.

### Why are the changes needed?

Fix: #3521 

### How was this patch tested?

Add a ut.

---------

Co-authored-by: xiaojiebao <xiaojiebao@xiaomi.com>
@jerryshao jerryshao added 0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 labels May 23, 2024
github-actions bot pushed a commit that referenced this issue May 23, 2024
@xloya @web-flow
[#3521] fix(client-python): Fix hash() function with multiple varia…
6a56e26 
…bles issue in `name_identitifer` (#3522)

### What changes were proposed in this pull request?

Fix `hash()` function in `name_identifier`.

### Why are the changes needed?

Fix: #3521 

### How was this patch tested?

Add a ut.

---------

Co-authored-by: xiaojiebao <xiaojiebao@xiaomi.com>
@jerryshao jerryshao mentioned this issue May 23, 2024
Merged
yuqi1129 pushed a commit that referenced this issue May 23, 2024
@jerryshao @xloya
[#3521] fix(client-python): Fix hash() function with multiple varia…
587be02 
…bles issue in `name_identitifer` (#3532)

### What changes were proposed in this pull request?

Fix `hash()` function in `name_identifier`.

### Why are the changes needed?

Fix: #3521 

### How was this patch tested?

Add a ut.

Co-authored-by: xloya <982052490@qq.com>
Co-authored-by: xiaojiebao <xiaojiebao@xiaomi.com>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@xloya @diqiu50
[apache#3521] fix(client-python): Fix hash() function with multiple…
8490a02 
… variables issue in `name_identitifer` (apache#3522)

### What changes were proposed in this pull request?

Fix `hash()` function in `name_identifier`.

### Why are the changes needed?

Fix: apache#3521 

### How was this patch tested?

Add a ut.

---------

Co-authored-by: xiaojiebao <xiaojiebao@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xloya xloya

Labels
0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@jerryshao @xloya