Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subdomain verification is broken #156

Closed
Benzoate opened this issue Jan 29, 2018 · 3 comments
Closed

Subdomain verification is broken #156

Benzoate opened this issue Jan 29, 2018 · 3 comments

Comments

@Benzoate
Copy link

TrustKit can erroneously identify other domains as subdomains, and as a result can use the wrong configuration.

I've tracked the issue to the isSubdomain function in configuration_utils.m, which is only checking that the domain names have the same ending.

Example:
2 configurations for domain.com and test-domain.com. Attempting to connect to en.test-domain.com will use the configuration for domain.com, rather than test-domain.com. Even worse is that totallynotthesamedomain.com will also identify as a subdomain of domain.com.
@nabla-c0d3
Copy link
Member

Thanks for the report and good catch! We will release a new version with the fix some time this week.

@nabla-c0d3
Copy link
Member

The fix was released as part of 1.5.3.

@Benzoate
Copy link
Author

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Benzoate @nabla-c0d3