Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling for score columns #792

Open
thinkh opened this issue Sep 26, 2022 · 1 comment
Open

Error handling for score columns #792

thinkh opened this issue Sep 26, 2022 · 1 comment
Assignees
Labels
type: bug Something isn't working

Comments

@thinkh
Copy link
Member

thinkh commented Sep 26, 2022

Environment

  • Release number or git hash:
  • Browser: Chrome 105
  • Deployed / Local:

Steps to reproduce the bug

  1. Open https://ordino-daily.caleydoapp.org/app/
  2. Load list of all CCLE lines
  3. Add gene score (aggregated): Chromosome 1, Normalized Gene Expression, Average

Observed Behavior

The column does not successfully load and stays in "Loading ..." state.
image

There is no error message shown, but the developer console might show an error (e.g., Gateway time-out).

Expected Behavior

Replace Loading ... with Error loading data in each cell.

@oltionchampari Please check the feasibility of this change.


Thanks for taking the time to fill out this bug report 🤗
Make sure there aren't any open/closed issues for this topic 😃

@thinkh thinkh added the type: bug Something isn't working label Sep 26, 2022
@oltionchampari
Copy link
Contributor

oltionchampari commented Sep 29, 2022

Did some investigating, and adding Error loading data is not a 5 minutes thing but should be possible by adding a different renderer . There is something already in place when the loading fails. An error notification is shown when the loading of the score fails but it does not seem to work (see sourcecode)
And i could not fix it that easily. We will not address this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants