Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Ambassador 0.50.0-ea7 tracing does not work with long cluster names #1025

Closed
flands opened this issue Dec 9, 2018 · 2 comments
Closed
Milestone

Comments

@flands
Copy link
Contributor

flands commented Dec 9, 2018

Describe the bug

If you enable tracing with a long cluster name then configuration will fail

To Reproduce

Two ways with different results:

Upgrade from 0.40.1 to 0.50.0-ea7 in a configuration with tracing enabled and long cluster name. Result is Ambassador in a CrashLoopBackoff

Deploy fresh 0.50.0-ea7 and then enabled tracing. Ambassador starts (assuming initially configured without tracing), but once tracing is enabled Ambassador configuration remains unchanged.

Expected behavior

No error, tracing works (given it works in Ambassador 0.40.1)

Versions (please complete the following information):

  • Ambassador: 0.50.0-ea7
  • Kubernetes environment [e.g. Minikube, bare metal, Google Kubernetes Engine]: bare metals
  • Version [e.g. 1.8.1]: 1.11.5

Additional context

[2018-12-08 00:05:23.027][000021][info][config] [source/server/configuration_impl.cc:103]   loading tracing driver: envoy.zipkin
[2018-12-08 00:05:23.028][000021][critical][main] [source/server/server.cc:81] error initializing configuration '/ambassador/bootstrap-ads.json': envoy.zipkin: unknown cluster 'cluster_tracing_jaeger_collector_default_svc_cluster_local_9411'
                    "cluster_name": "cluster_tracing_jaeger_collector_default-0",
                    "endpoints": [
                        {
                            "lb_endpoints": [
                                {
                                    "endpoint": {
                                        "address": {
                                            "socket_address": {
                                                "address": "jaeger-collector.default.svc.cluster.local",
                                                "port_value": 9411,
                                                "protocol": "TCP"
                                            }
                                        }
                                    }
                                }
                            ]
                        }
                    ]
                },
                "name": "cluster_tracing_jaeger_collector_default-0",
                "type": "STRICT_DNS"
            }
        ]
    },
    "tracing": {
        "http": {
            "config": {
                "collector_cluster": "cluster_tracing_jaeger_collector_default_svc_cluster_local_9411"
            },
            "name": "envoy.zipkin"
        }
@flands
Copy link
Contributor Author

flands commented Dec 9, 2018

/cc @kflynn

@flands flands changed the title Regression: Ambassador 0.50.0-ea7 tracing does not work with long names Regression: Ambassador 0.50.0-ea7 tracing does not work with long cluster names Dec 9, 2018
@richarddli richarddli added this to the 0.50.0 GA milestone Dec 10, 2018
kflynn pushed a commit that referenced this issue Dec 17, 2018
@kflynn
Copy link
Member

kflynn commented Dec 20, 2018

Fixed in -rc1.

@kflynn kflynn closed this as completed Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants