Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable upstream idle_timeout #1542

Closed
esmet opened this issue May 15, 2019 · 3 comments
Closed

Configurable upstream idle_timeout #1542

esmet opened this issue May 15, 2019 · 3 comments
Labels
stale Issue is stale and will be closed

Comments

@esmet
Copy link
Contributor

esmet commented May 15, 2019

Please describe your use case / problem.
I'd like to configure how long keepalive connections are kept for upstream clusters.

Describe the solution you'd like
We can set the upstream cluster timeout on https://www.envoyproxy.io/docs/envoy/v1.9.0/api-v2/api/v2/core/protocol.proto#envoy-api-msg-core-httpprotocoloptions in v2/v2cluster.py

Describe alternatives you've considered
There is currently no alternative. I believe there is no upstream timeout at all unless one is set on the cluster object.

Additional context
I think it would make sense to allow this to be per mapping, but since it would mean the generation of a new cluster for every distinct timeout, this might not be possible/advisable. Is that right? Either way, the ability to set this globally would be enough satisfy my use case in the near term.

@esmet
Copy link
Contributor Author

esmet commented May 15, 2019

I currently have a naive implementation but would be willing to clean it up before submitting a PR

@stale
Copy link

stale bot commented Jul 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is stale and will be closed label Jul 14, 2019
@stale stale bot closed this as completed Jul 21, 2019
@kflynn
Copy link
Member

kflynn commented Jul 30, 2019

This actually got fixed -- thanks @esmet!

alexgervais pushed a commit that referenced this issue Jul 10, 2020
…context

Extend Host with tls: and tlsContext:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue is stale and will be closed
Projects
None yet
Development

No branches or pull requests

2 participants